ci: fix docs-only filter to properly skip tests for documentation changes#4066
Merged
blackgirlbytes merged 1 commit intomainfrom Aug 13, 2025
Merged
ci: fix docs-only filter to properly skip tests for documentation changes#4066blackgirlbytes merged 1 commit intomainfrom
blackgirlbytes merged 1 commit intomainfrom
Conversation
…nges The current CI workflow runs all tests even for documentation-only PRs, despite having a changes job intended to detect and skip these scenarios. The code filter uses '**' as an inclusion pattern, which causes it to evaluate to true whenever any files are changed, regardless of the exclusion patterns that follow. This change removes the '**' pattern and uses only exclusion patterns for the code filter, and expands markdown detection to include subdirectories with '**/*.md' instead of just '*.md'. Result: Documentation-only PRs will have code = false, properly skipping expensive CI jobs while still triggering full CI for actual code changes.
blackgirlbytes
requested review from
EbonyLouis,
acekyd,
angiejones,
dianed-square and
iandouglas
iandouglas
approved these changes
Aug 13, 2025
katzdave
added a commit
that referenced
this pull request
Aug 13, 2025
* 'main' of github.com:block/goose: fix(build): feed electronforge the icon explicitly for linux (#4045) Docs: Troubleshooting tip - Nodejs path on windows (#4065) fix: flag out uncompilable bit in windows (#4068) ci: fix docs-only filter to properly skip tests for documentation changes (#4066) fix: ctrl-C interruption in the CLI (#4057)
zanesq
added a commit
that referenced
this pull request
Aug 13, 2025
* 'main' of github.com:block/goose: (120 commits) Docs: Troubleshooting tip - Nodejs path on windows (#4065) fix: flag out uncompilable bit in windows (#4068) ci: fix docs-only filter to properly skip tests for documentation changes (#4066) fix: ctrl-C interruption in the CLI (#4057) docs: mcp-ui support (#4049) fix: delete dialog layout (#4037) ci: fix markdown file pattern to skip builds for all .md files (#4061) docs: add window title (#4059) blog: cleaning up some posts (#4050) fix: this should be a debug message not a warn (#4024) Better provider logging (#4052) feat: ToolError migration to ErrorData (#4051) docs: rename sessions (#4053) Add mcp automated testing blog (#4004) MCP session replay integration test (#3939) Docs: Cost tracking in CLI (#4043) sanitize message content on deserialization (#3966) Move summarize button inside of context view (#4015) blog: post on lead/worker model (#3994) Actually send cancellation to MCP servers (#3865) ...
jsibbison-square
added a commit
that referenced
this pull request
Aug 14, 2025
…ol-visibility * origin/main: (43 commits) docs: Blog - How I Used Goose to Rebuild My Website (#4076) docs: custom context file names (#4077) Blog: How Pulse MCP Used Goose to Automate Their Newsletter (#4075) Load recipe deeplinks in single window when app is closed (#4048) docs: make accurate the comments with links to unsigned builds of the app (#4070) cleanup memory in chat (#4073) CLI: improve model selection ux (#4071) speed up loading extensions by loading in parallel (#4054) fix(build): feed electronforge the icon explicitly for linux (#4045) Docs: Troubleshooting tip - Nodejs path on windows (#4065) fix: flag out uncompilable bit in windows (#4068) ci: fix docs-only filter to properly skip tests for documentation changes (#4066) fix: ctrl-C interruption in the CLI (#4057) docs: mcp-ui support (#4049) fix: delete dialog layout (#4037) ci: fix markdown file pattern to skip builds for all .md files (#4061) docs: add window title (#4059) blog: cleaning up some posts (#4050) fix: this should be a debug message not a warn (#4024) Better provider logging (#4052) ...
This was referenced Aug 18, 2025
ayax79
pushed a commit
to ayax79/goose
that referenced
this pull request
Aug 21, 2025
…nges (block#4066) Signed-off-by: Jack Wright <jack.wright@nike.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix CI workflow to properly skip tests for documentation-only changes
Problem
The current CI workflow runs all tests even for documentation-only PRs (like #4004), despite having a
changesjob intended to detect and skip these scenarios.Root Cause
The
codefilter uses'**'as an inclusion pattern, which causes it to evaluate totruewhenever any files are changed, regardless of the exclusion patterns that follow:Solution
Remove the
'**'pattern and use only exclusion patterns for thecodefilter. Also expand markdown detection to include subdirectories:Result
code = false, properly skipping expensive CI jobsTesting
This change would have prevented the unnecessary CI runs on PR #4004, which only modified files under
documentation/blog/.Tested on my forked PR
Docs change
Skipped the other unneeded build test
Code change
Included the other build test
